Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Tree-sitter 0.15.5 (with travis build) #19531

merged 2 commits into from Jun 14, 2019


Copy link

commented Jun 13, 2019

This PR bumps the tree-sitter to 0.15.5, which contains the very latest version of the core Tree-sitter library.

We were already using almost the latest version, after yesterday's upgrade due to #19497, but this brings us up to master.

Small Behavior Change

There was a small fix to the behavior of the ts_node_descendant_for_position method in Tree-sitter, which slightly changes the behavior of some methods in Atom:

In particular, it fixes what I consider to be a bug in the behavior of the editor:select-larger-syntax-node where if you had your cursor between two adjacent tokens it would select the token before the cursor instead of the token immediately afterward.

It also fixes what I think was a bug in the bufferRangeForScopeAtPosition method. I've updated a test to reflect that change.

Prebuilt Binaries

Today I merged tree-sitter/node-tree-sitter#50, which I think may make it so that the prebuilt linux binaries of tree-sitter will work for Atom, so that we don't have to manually delete those binaries to avoid weird hangs on Travis. 馃

@maxbrunsfeld maxbrunsfeld merged commit 61ef7ff into master Jun 14, 2019

2 checks passed

Atom Pull Requests #20190614.8 succeeded
continuous-integration/travis-ci/push The Travis CI build passed

@maxbrunsfeld maxbrunsfeld deleted the mb-tree-sitter-0-15-5-test-travis branch Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can鈥檛 perform that action at this time.