Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ electron-winstaller@3.0.4 #19539

merged 2 commits into from Jun 17, 2019


Copy link

commented Jun 14, 2019

This PR upgrades the version of electron-winstaller that's being used by Atom. This is a preparation work to be able to ship nightly releases for Atom (more info in #17884 (comment)).

Test plan

I haven't been able to fully test the whole installation mechanism, but these are the things that I've tested:

  • I've enabled production builds and code signing on this branch and checked that Azure is able to build the installer correctly (build results). The failure is not related to the package update: it's caused by an issue that prevents fully building signed nupkg files from non-production branches (I've asserted this by getting the same failure when enabling signed builds on a branch with no changes).
  • I've downloaded the AtomSetup-x64.exe installer from this branch build results and checked that Atom can correctly be installed and executed on Windows.

Checks that I'll do once this PR gets merged:

  • Verify that master builds can still be generated. Based on my testing there shouldn't be any issue on master, but I'll double check that.
  • Verify that Nightly builds can still be generated correctly. I'll wait until the next nightly build (which happens at 5am GMT) and verify that it worked fine.
  • Verify that nupkg files are working correctly. To do so, I currently have a Win64 VM with the latest Atom nightly build installed (1.40.0-nightly4). Once this PR gets merged and the new nightly release gets generated with this changes, I'll check if my Atom installation gets upgraded successfully. If there's any issue with the upgrades I'll revert the changes.

Once I've run these checks, I'll be relatively confident that this PR does not break stuff (I cannot be more confident than that given my familiarity with the logic to generate Windows releases and the autoupdate mechanism 😅).

@rafeca rafeca force-pushed the upgrade-electron-winstaller branch from 7a3817d to 0e7d99d Jun 17, 2019

@rafeca rafeca requested a review from jasonrudolph Jun 17, 2019

@rafeca rafeca marked this pull request as ready for review Jun 17, 2019


This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

Once this gets merged, I'll be able to remove this line from the windows installer generation, which will enable delta installations and will remove the warnings on our Nightly release pipeline builds:

Screenshot 2019-06-17 at 19 51 02

@rafeca rafeca merged commit fae8032 into master Jun 17, 2019

1 check passed

Atom Pull Requests #20190617.8 succeeded

@rafeca rafeca deleted the upgrade-electron-winstaller branch Jun 17, 2019


This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

Cool! master builds are passing correctly, the latest nightly succeeded running and my Atom installation running on nightly-4 has detected and upgraded correctly to nightly-5:

Screenshot 2019-06-18 at 09 17 55

So all the follow-up checks are successful 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.