Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delays that we no longer need in watch-path tests #19551

Merged
merged 1 commit into from Jun 17, 2019

Conversation

@jasonrudolph
Copy link
Member

commented Jun 17, 2019

This pull request reverts the changes introduced in #19459. With the upgrade to atom/nsfw v1.0.25 in #19525, we should no longer need the delays introduced in #19459. 馃槄

To gain confidence that we no longer need these delays, I pushed up a temporary commit to run these two tests 10,000 times on CI:

  • The first test ran successfully 10,000 times.
  • The second test ran successfully 7,406 times before the CI job timed out. (It turns out that Azure Pipelines didn't want to keep running a build that's already been running for 3 hours. 馃槆馃槄) Despite "only" running 7,406 times, I think we can safely assume that this test no longer needs the delays introduced in #19459.

Refs: #19442

Revert "add delay to watch-path tests to make them less flaky"
This reverts commit dd40782. With the upgrade to atom/nsfw v1.0.25 in
#19525, we should no longer  need the
delay introduced in dd40782.

@jasonrudolph jasonrudolph requested review from rafeca and as-cii Jun 17, 2019

@jasonrudolph jasonrudolph self-assigned this Jun 17, 2019

@as-cii

as-cii approved these changes Jun 17, 2019

Copy link
Contributor

left a comment

Nice! 鈿★笍鈿★笍鈿★笍

@jasonrudolph jasonrudolph merged commit c7c082f into master Jun 17, 2019

1 check passed

Atom Pull Requests #20190617.5 succeeded
Details

@jasonrudolph jasonrudolph deleted the revert-19459 branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.