Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ electron-winstaller #19573

Merged
merged 1 commit into from Jun 19, 2019

Conversation

@rafeca
Copy link
Contributor

commented Jun 19, 2019

With this PR Atom uses a custom version of electron-winstaller that contains a custom version of Squirrel.Windows built from Squirrel/Squirrel.Windows#1492 .

This should fix the issues when upgrading from e.g nightly-9 to nightly-10.

Verification plan

  • Check that this PR gets built correctly.
  • Enable production and signed builds on this branch and check that the PR gets built correctly.
  • Merge this PR and then Queue a new Atom Nightly build to check that nightly builds are still working.
  • Check that a Windows Atom Nightly installation gets upgraded to the created nightly build.
  • Create yet another Atom Nightly build and check that the previously upgraded Atom Nightly build can get upgraded again.
  • Create an Atom Nightly build with a prerelease number >=10 and check that a Windows nightly with prerelease number <10 can be upgraded successfully.

@rafeca rafeca force-pushed the custom-electron-winstaller branch from 0c1e550 to 44b077f Jun 19, 2019

⬆️ electron-winstaller
With this PR Atom uses a custom version of `electron-winstaller` named
`@atom/electron-winstaller` which contains a custom version of `Squirrel.Windows`
built from Squirrel/Squirrel.Windows#149

This should fix the issues when upgrading from e.g nightly-9 to
nightly-10

@rafeca rafeca force-pushed the custom-electron-winstaller branch 2 times, most recently from 441d381 to 2c516fb Jun 19, 2019

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

  • Enable production and signed builds on this branch and check that the PR gets built correctly.

The production signed builds are fine: https://github.visualstudio.com/Atom/_build/results?buildId=43751 (the error is expected, see first point on the test plan of #19539).

Next step is to merge this PR and generate a nightly build 🤞

@rafeca rafeca merged commit 95f8cf8 into master Jun 19, 2019

1 check was pending

Atom Pull Requests in progress
Details

@rafeca rafeca deleted the custom-electron-winstaller branch Jun 19, 2019

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

  • Merge this PR and then Queue a new Atom Nightly build to check that nightly builds are still working.

Nightly build has run successfully and has created atom v1.40.0-nightly7: https://dev.azure.com/github/Atom/_build/results?buildId=43773

Next step is to test that an Atom installation on nightly-6 updates correctly 😃

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

  • Check that a Windows Atom Nightly installation gets upgraded to the created nightly build.

My Atom installation got upgraded successfully from nightly-6 to nightly-7:

Screenshot 2019-06-19 at 20 37 54

Next step is to trigger another Nightly build to get nightly-8 released and check that nightly-7 gets upgraded without issues.

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

  • Create yet another Atom Nightly build and check that the previously upgraded Atom Nightly build can get upgraded again.

The upgrade happened successfully:

Screenshot 2019-06-19 at 21 41 34

Next step is to publish atom nightly-10 and check that Atom can be upgraded correctly.

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

  • Create an Atom Nightly build with a prerelease number >=10 and check that a Windows nightly with prerelease number <10 can be upgraded successfully.

I've created nightly-10 and Atom unfortunately nightly-9 is not able to upgrade to it 😟 I'll check what has gone wrong tomorrow

@Arcanemagus

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

I've created nightly-10 and Atom unfortunately nightly-9 is not able to upgrade to it 😟

Odd, I was able to upgrade from -nightly4 to -nightly9 to -nightly10 with no issues on Windows 10 x64.

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

I've created nightly-10 and Atom unfortunately nightly-9 is not able to upgrade to it 😟 I'll check what has gone wrong tomorrow

Quick update: the upgrade from nightly-9 to nightly-10 worked successfully! It just took a bit longer than usual 😅 . Both me and @Arcanemagus have got the update correctly 😃

@Ben3eeE

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Worked for me as well going from -nightly2 to -nightly10 and then to nightly11 🎉

@rafeca rafeca referenced this pull request Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.