Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when multiple language layers are not yet highlighted #19575

Merged
merged 1 commit into from Jun 19, 2019

Conversation

@maxbrunsfeld
Copy link
Contributor

commented Jun 19, 2019

This fixes a regression introduced in #19556.

The code introduced in that PR ☝️ relied on the existence of a property LayerHighlightIterator.languageLayer which was not present on the NullHighlightIterator. This caused intermittent exceptions in the case where there were multiple injected language layers whose asynchronous parsing had not yet completed.

@maxbrunsfeld maxbrunsfeld force-pushed the mb-fix-tree-sitter-highlight-exception branch from 27fb5ce to 288cd12 Jun 19, 2019

@as-cii

as-cii approved these changes Jun 19, 2019

Copy link
Contributor

left a comment

Nice catch!

@maxbrunsfeld maxbrunsfeld merged commit 4027b0b into master Jun 19, 2019

1 check passed

Atom Pull Requests #20190619.14 succeeded
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-fix-tree-sitter-highlight-exception branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.