Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run script/bootstrap for pull requests originated from forks #19577

Merged
merged 1 commit into from Jun 20, 2019

Conversation

@as-cii
Copy link
Contributor

commented Jun 20, 2019

Fixes #19543

The artifact caching task does not work on forks, so we need to bootstrap again on each parallel test suite for pull requests originated via a forked repository.

@as-cii as-cii requested a review from rafeca Jun 20, 2019

@as-cii as-cii merged commit 7e763a2 into master Jun 20, 2019

1 check passed

Atom Pull Requests #20190620.6 succeeded
Details

@as-cii as-cii deleted the as/fix-ci-for-forked-pull-requests branch Jun 20, 2019

@Aerijo

This comment has been minimized.

@as-cii

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

Thanks for the heads-up, @Aerijo. Apologies for this! Unfortunately, it's kinda hard for me to test this behavior. Can you try pulling from as/upgrade-npm-for-macos-tests and see if it works? If so, I'll go ahead and merge it into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.