Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different polkit policy name for each Atom channel on Linux #19578

Merged
merged 3 commits into from Jun 20, 2019

Conversation

@as-cii
Copy link
Contributor

commented Jun 20, 2019

Refs: #17884 (comment)

Using the same name would generate an exception when trying to install more than one version of Atom at the same time.

Antonio Scandurra
Use a different polkit policy name for each Atom channel on Linux
Using the same name would generate an exception when trying to install 
more than one version of Atom at the same time.

@as-cii as-cii requested a review from rafeca Jun 20, 2019

@rafeca
Copy link
Contributor

left a comment

Wow that was fast! Thanks a lot!! 🤗

I added a couple of comments with questions (I'm not super familiar about rpm or deb generation).

resources/linux/redhat/atom.spec.in Show resolved Hide resolved

Antonio Scandurra added some commits Jun 20, 2019

@rafeca

rafeca approved these changes Jun 20, 2019

Copy link
Contributor

left a comment

🎉🎊🎉🎊🎉🎊

@as-cii as-cii merged commit 639a126 into master Jun 20, 2019

1 check passed

Atom Pull Requests #20190620.9 succeeded
Details

@as-cii as-cii deleted the as/fix-policy-files branch Jun 20, 2019

@rafeca

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

I've tested the latest nightly on my Ubuntu VM and this fixes the problem. After installing atom-beta and atom-nightly we have this polkit policies:

$ ls /usr/share/polkit-1/actions/atom*
  /usr/share/polkit-1/actions/atom-nightly.policy
  /usr/share/polkit-1/actions/atom.policy

I've also verified that the polkit integration works correctly when having the two policies.

@as-cii should we cherry-pick this change on the 1.39-releases branch to be sure that users that have the beta installed don't experience this problem when the polkit changes go to stable?

as-cii pushed a commit that referenced this pull request Jun 21, 2019

Antonio Scandurra
Merge pull request #19578 from atom/as/fix-policy-files
Use a different polkit policy name for each Atom channel on Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.