Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Electron crash reports to Bugsnag via if user has consented to Telemetry #19591

merged 6 commits into from Jun 25, 2019


Copy link

commented Jun 24, 2019

馃崘'd with @jasonrudolph

Currently, we are not capturing crashes of the Electron render process or main process that occur in production. With this PR, we tell the Electron crash reporter that we want to upload crash reports to if the user has consented to telemetry. We include the value of require('os').release() and require('os').arch() as well as the releaseChannel as extra fields to be sent by the reporter.

I will open another PR on that uses the reported information to report the crash to Bugsnag via Bugsnag's REST API.

@nathansobo nathansobo self-assigned this Jun 24, 2019

@as-cii as-cii merged commit a2f5f59 into master Jun 25, 2019

1 check passed

Atom Pull Requests #20190624.5 succeeded

@as-cii as-cii deleted the ns-jr/upload-crash-reports branch Jun 25, 2019


This comment has been minimized.

Copy link

commented Jun 26, 2019

This should be documented on the metrics repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can鈥檛 perform that action at this time.