Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn updated Atom immediately instead of waiting for `will-quit` event #19594

Merged
merged 2 commits into from Jun 25, 2019

Conversation

@as-cii
Copy link
Contributor

commented Jun 25, 2019

Fixes #19493

Spawning the new version of Atom within a will-quit handler would cause Electron to quit before having a chance to actually run the executable.

There may still be a possibility of raciness between closing the old version of Atom and opening the new one, causing resource contention between the two processes (e.g., IndexedDb) or failing to spawn the new process before the previous one quits. Addressing such raciness perfectly would require a much more complex solution and this approach is working for us consistently in our tests.

馃崘'd with @nathansobo

Spawn updated Atom immediately instead of waiting for `will-quit` event
Spawning the new version of Atom within a `will-quit` handler would 
cause Electron to quit before having a chance to actually run the 
executable.

There may still be a possibility of raciness between closing the old 
version of Atom and opening the new one, causing resource contention 
between the two processes (e.g., IndexedDb) or failing to spawn the new 
process before the previous one quits. Addressing such raciness 
perfectly would require a much more complex solution and this approach 
is working for us consistently in our tests.

Co-Authored-By: Nathan Sobo <nathan@github.com>
Delete implementation-dependent test
Co-Authored-By: Nathan Sobo <nathan@github.com>

@as-cii as-cii merged commit 4da97a5 into master Jun 25, 2019

1 check passed

Atom Pull Requests #20190625.3 succeeded
Details

@as-cii as-cii deleted the as-ns/fix-restarting-after-update-on-windows branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.