Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send OS version to the autoupdate endpoint #19607

Merged
merged 1 commit into from Jun 27, 2019

Conversation

Projects
None yet
1 participant
@rafeca
Copy link
Contributor

commented Jun 27, 2019

Context

Atom is going to be upgraded to use Electron v4 (PR: #19373), and since that new version of Electron does not support OSX < 10.10, we need to make users of older OSX versions to stick to a version of Atom that uses Electron v3.

Solution

We're going to add some custom logic on the autoupdate backend to force clients on older OSX versions to stick to the latest Atom stable/beta/nightly version that uses Electron v3.

In order to do so, we need to send the os_version parameter to the autoupdate backend, which is what this PR is doing 馃槂

More information in this comment.

@rafeca rafeca merged commit b6dd340 into master Jun 27, 2019

1 check passed

Atom Pull Requests #20190627.1 succeeded
Details

@rafeca rafeca deleted the send-os-version branch Jun 27, 2019

rafeca added a commit that referenced this pull request Jul 2, 2019

Merge pull request #19607 from atom/send-os-version
Send OS version to the autoupdate endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.