Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore use of Ubuntu 14.04 for Linux CI builds #19617

Merged
merged 5 commits into from Jul 25, 2019

Conversation

@as-cii
Copy link
Contributor

commented Jul 1, 2019

As part of the transition from Travis CI to Azure Pipelines to build Atom on Linux in #19597, we started using Ubuntu 18.04 as opposed to Ubuntu 14.04. This caused unintended side effects, such as #19692, #19690 and #19682.

Even though, as @mfonville pointed out, standard support for Ubuntu 14.04 ended in April 2019, we still want to support users running Atom on Fedora and CentOS 7. It is possible that we would able to do so by using Ubuntu 16, but for now using an Ubuntu version that we know works seems like the most pragmatic solution.

馃崘'd with @jasonrudolph

@as-cii as-cii force-pushed the as/downgrade-ubuntu branch 3 times, most recently from f4161a5 to 2813684 Jul 1, 2019

@mfonville

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

Didn't 14.04 lose end of standard support in last April? I thought 16.04 is the lowest version that is still having free support.

@as-cii

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

Closing this, as we decided to upgrade to a newer Ubuntu distro on the packages' CI whose tests were failing.

@as-cii as-cii closed this Jul 2, 2019

@Arcanemagus Arcanemagus deleted the as/downgrade-ubuntu branch Jul 2, 2019

@as-cii as-cii restored the as/downgrade-ubuntu branch Jul 24, 2019

@as-cii as-cii reopened this Jul 24, 2019

Antonio Scandurra

@as-cii as-cii force-pushed the as/downgrade-ubuntu branch from 661f404 to 445548e Jul 24, 2019

Antonio Scandurra and others added some commits Jul 24, 2019

Revert "WIP: Temporarily upload artifacts on builds triggered by pull鈥
鈥 requests"

This reverts commit 10fc3f2.

Co-Authored-By: Jason Rudolph <jason@jasonrudolph.com>
Re-enable CI for Windows and macOS on Azure pipelines
Co-Authored-By: Jason Rudolph <jason@jasonrudolph.com>

@as-cii as-cii changed the title Downgrade Ubuntu to 14.04 Restore use of Ubuntu 14.04 for Linux CI builds Jul 24, 2019

@as-cii as-cii marked this pull request as ready for review Jul 24, 2019

@jasonrudolph

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

We now have candidate builds of 1.39 and 1.40 that include this fix:

So far, we've tested these candidate builds on CentOS 7, Fedora 25, and Ubuntu 18.04, and the builds seem to resolve the issues reported in #19690, #19692, and #19682. I've asked the authors of those issues to test out the candidate build for 1.39 and let us know if it resolves the issue for them. If it does, then we'll merge this pull request and publish new 1.39.1 and 1.40.0-beta1 with this fix.

@jasonrudolph

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

So far, we've tested these candidate builds on CentOS 7, Fedora 25, and Ubuntu 18.04, and the builds seem to resolve the issues reported in #19690, #19692, and #19682. I've asked the authors of those issues to test out the candidate build for 1.39 and let us know if it resolves the issue for them. If it does, then we'll merge this pull request and publish new 1.39.1 and 1.40.0-beta1 with this fix.

We've had a handful of confirmations (#19682 (comment), #19690 (comment)) that these changes resolve the issues installing the RPM package, so I think we can go ahead and merge these changes.

@jasonrudolph jasonrudolph merged commit 99faf0f into master Jul 25, 2019

1 check passed

Atom Pull Requests #20190724.5 succeeded
Details

@jasonrudolph jasonrudolph deleted the as/downgrade-ubuntu branch Jul 25, 2019

jasonrudolph added a commit that referenced this pull request Jul 25, 2019

Restore use of Ubuntu 14.04 for Linux CI builds
Cherry-pick #19617 onto 1.40-releases branch

Co-authored-by: Antonio Scandurra <as-cii@github.com>

jasonrudolph added a commit that referenced this pull request Jul 25, 2019

Restore use of Ubuntu 14.04 for Linux CI builds
Cherry-pick #19617 onto 1.39-releases branch

Co-authored-by: Antonio Scandurra <as-cii@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.