Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when ripgrep returns matches that are empty #19618

Merged
merged 1 commit into from Jul 1, 2019

Conversation

@rafeca
Copy link
Contributor

commented Jul 1, 2019

There can be searches where ripgrep returns an empty string as a result, like the added spec where the user searches for lines with no indentation (interestingly, this seems to not work using the standard searcher). The ripgrep scanner was not handling well this situation since the check for existance of the text key was not restrictive enough.

This PR fixes it

@rafeca rafeca merged commit 3210eac into master Jul 1, 2019

1 check passed

Atom Pull Requests #20190701.4 succeeded
Details

@rafeca rafeca deleted the fix-empty-result branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.