Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct executable name on the code signing tool #19675

Merged
merged 1 commit into from Jul 16, 2019

Conversation

@rafeca
Copy link
Contributor

commented Jul 16, 2019

#17813 has introduced an issue on the code signing step (which is only executed when running production builds) that is causing CI failures.

The problem is that the signing logic had Atom.exe hardcoded, while now the executable name is dynamic and depends on the release channel (e.g atom-beta.exe, atom-nightly.exe, atom.exe). This PR fixes the issue by reusing the CONFIG param that calculates the executable name.

I've double checked that there are no more atom.exe hardcoded in the atom repo, but it's possible that more issues arise after fixing this 馃.

@rafeca rafeca merged commit 35bc01f into master Jul 16, 2019

1 check passed

Atom Pull Requests #20190716.3 succeeded
Details

@rafeca rafeca deleted the fix-signing-issues branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.