Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not depend on CONFIG.executableName on the windows tests #19676

Merged
merged 1 commit into from Jul 17, 2019

Conversation

@rafeca
Copy link
Contributor

commented Jul 17, 2019

CONFIG.executableName depends on the ATOM_RELEASE_VERSION env variable to work correctly on nightly releases.

Since this env variable is not being set for the testing steps, the nightly release builds contain a wrong executableName on the testing step, which causes a failure when trying to find the Atom executable.

This commit fixes that by stop using the executableName from the test step, like it's done on other platforms, and should fix the current failures that are happening on nightly.

Do not depend on CONFIG.executableName on the windows tests
CONFIG.executableName depends on the ATOM_RELEASE_VERSION env variable
to work correctly on nightly releases.

Since this env variable is not being set for the testing steps, the
nightly release builds contain a wrong executableName on the testing
step, which causes a failure when trying to find the Atom executable.

This commit fixes that by stop using the executableName from the test
step, like it's done on other platforms.

@rafeca rafeca merged commit f2b246f into master Jul 17, 2019

1 check passed

Atom Pull Requests #20190717.1 succeeded
Details

@rafeca rafeca deleted the fix-tests-on-nightly branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.