Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate correctly the nupkg filenames when uploading artifacts #19678

Merged
merged 1 commit into from Jul 17, 2019

Conversation

@rafeca
Copy link
Contributor

commented Jul 17, 2019

As part of #17813, the filenames of the nupkg files have changed and this is causing more issues than expected.

This PR fixes the latest issue found, which prevents the Azure pipelines from uploading the artifacts correctly. This was caused by having the filenames hardcoded, so the easiest solution is to calculate the correct application name in JS and pass it back to Azure as a build variable (like we're doing for other data like the app version).

An easier solution would have been to just use globs or wildcards on the PathToPublish param for the upload artifacts step, but unfortunately Azure Pipelines does not support them.

@rafeca rafeca merged commit 8ef1309 into master Jul 17, 2019

1 check passed

Atom Pull Requests #20190717.3 succeeded
Details

@rafeca rafeca deleted the fix-uploading-artifacts branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.