Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use class colors for inherited classes in One syntax themes #19735

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@as-cii
Copy link
Contributor

commented Jul 31, 2019

Closes #19588

This pull request introduces a more consistent syntax highlighting for inherited classes. In particular, we will start using @hue-6-2 in One syntax themes to avoid making them look like strings. This is the same hue that is used for class declarations.

One Light

Before After
Screen Shot 2019-07-31 at 17 19 56 Screen Shot 2019-07-31 at 17 19 35

One Dark

Before After
Screen Shot 2019-07-31 at 17 20 02 Screen Shot 2019-07-31 at 17 19 21

/cc: @silentsokolov

@rsese

rsese approved these changes Jul 31, 2019

Copy link
Member

left a comment

I think this is definitely more clear, thanks @as-cii 🙇

@as-cii as-cii merged commit 0be7365 into master Aug 1, 2019

1 check passed

Atom Pull Requests #20190731.1 succeeded
Details

@as-cii as-cii deleted the as/change-inherited-class-color branch Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.