Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Avoid covering up scopes at boundaries of injection layers #19738
@as-cii I tweaked the implementation to use the syntax Tree instead of the buffer range to detect whether an iterator is at the start of end of its injection.
My concern about using the range is that the layers' ranges can change over time as the document is edited, so if we store a
I think there are still there are theoretically cases where we might erroneously cover scope boundaries with this logic, and we should probably be even more restrictive about when we cover scope boundaries, but I can't think of a concrete case where they would occur, so I think this idea is a good way to fix the problem we're currently seeing.