Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敟 Remove unused TimeReporter class #19763

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@jasonrudolph
Copy link
Member

commented Aug 8, 2019

Closes #13927


#13927 (comment) identified that there's a bug in spec/time-reporter.coffee, but that it's also not being used anywhere:

I'm not sure if this actually has any impact since it never actually worked and I don't know of anyone (including atom) that actually uses this file.

A better fix might be deleting the file.

So, let's remove it. 馃槄

@jasonrudolph

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

As far as I can tell, the last use of spec/time-reporter.coffee was removed in f01a2a9.

@jasonrudolph jasonrudolph marked this pull request as ready for review Aug 8, 2019

@jasonrudolph jasonrudolph merged commit 08a0862 into master Aug 8, 2019

1 check passed

Atom Pull Requests #20190808.1 succeeded
Details

@jasonrudolph jasonrudolph deleted the remove-time-reporter branch Aug 8, 2019

@jasonrudolph jasonrudolph self-assigned this Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.