Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ language-php@0.443 #20041

Merged
merged 2 commits into from Oct 22, 2019
Merged

⬆️ language-php@0.443 #20041

merged 2 commits into from Oct 22, 2019

Conversation

@darangi
Copy link
Contributor

darangi commented Oct 21, 2019

List of changes between language-php@0.44.2 and language-php@0.44.3: atom/language-php@v0.44.2...v0.44.3

Refs: atom/language-php#369 (Thanks for the contributions, @KapitanOczywisty! 🙇)

Release Notes

Fix PHP syntax highlighting issue for ternary operator, ereg functions, and comments within closures

@jasonrudolph jasonrudolph changed the title :arrow_up:language-php@0.443 ⬆️ language-php@0.443 Oct 21, 2019
package.json Outdated Show resolved Hide resolved
Copy link
Member

jasonrudolph left a comment

Since this pull request is focused on upgrading language-php, I think we should remove the changes related to language-typescript. I've included some suggested edits below that I think will do the trick.

package-lock.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Change language-typescript@0.5.2 to language-typescript@0.5.3

Co-Authored-By: Jason Rudolph <jason@jasonrudolph.com>
Copy link
Member

jasonrudolph left a comment

Nice work, @darangi!

@jasonrudolph

This comment has been minimized.

Copy link
Member

jasonrudolph commented Oct 21, 2019

CI is green!

@darangi @lkashef: Feel free to merge this. 😄

@darangi darangi merged commit 26d314b into atom:master Oct 22, 2019
1 check passed
1 check passed
Atom Pull Requests #20191021.2 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.