Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tree-sitter to 0.15.13 #20061

merged 1 commit into from Oct 29, 2019


Copy link

maxbrunsfeld commented Oct 24, 2019

This PR updates the tree-sitter module to include some recent changes:

  • tree-sitter/node-tree-sitter#45, which makes the library compatible with Node 12, and removes uses of deprecated V8 APIs. This way, whenever we decide to upgrade Electron, Tree-sitter won't be a blocker.
  • tree-sitter/tree-sitter#334, which adds forward-compatible support for the next Tree-sitter parser ABI, which further reduces the binary sizes and static memory footprints of Tree-sitter parsers. Once a version of Atom is released with this support, I can start regenerating Tree-sitter parsers with the new ABI.
@maxbrunsfeld maxbrunsfeld force-pushed the mb-tree-sitter-0.15.10-test-travis branch from b9462e1 to 08575aa Oct 24, 2019
@maxbrunsfeld maxbrunsfeld changed the title Update tree-sitter to 0.15.10 Update tree-sitter to 0.15.13 Oct 28, 2019
@maxbrunsfeld maxbrunsfeld force-pushed the mb-tree-sitter-0.15.10-test-travis branch from 391ef41 to ab0cdf1 Oct 28, 2019
@maxbrunsfeld maxbrunsfeld force-pushed the mb-tree-sitter-0.15.10-test-travis branch from ab0cdf1 to 1e6d6f2 Oct 28, 2019
@@ -157,8 +157,7 @@
"temp": "^0.9.0",
"text-buffer": "13.17.0",
"timecop": "",
"tree-sitter": "0.15.6",
"tree-sitter-css": "^0.13.7",

This comment has been minimized.

Copy link

maxbrunsfeld Oct 28, 2019

Author Contributor

The tree-sitter-css module shouldn't be listed as a direct dependency here. I added that by mistake; it's only used by language-css module, which depends on it explicitly.

@maxbrunsfeld maxbrunsfeld merged commit ab5e06a into master Oct 29, 2019
1 check passed
1 check passed
Atom Pull Requests #20191028.3 succeeded
@maxbrunsfeld maxbrunsfeld deleted the mb-tree-sitter-0.15.10-test-travis branch Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.