Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: Update npm to 6.14.4 for Python 3 support #20711

Merged
merged 1 commit into from May 12, 2020

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented May 8, 2020

Identify the Bug

Addresses part of #20585

Description of the Change

Update package dependencies for the build scripts, so as to support building Atom with Python 3.

Updates the npm package in package.json and package-lock.json under the scripts/ directory of this repo; Updates npm to 6.14.4, which comes with node-gyp 5.1.0, which now supports Python 3.

Does not affect anything but the build process itself. Should not affect the end result or change the built Atom packages. This is about still being able to build Atom as distros begin to drop Python 2.

Alternate Designs

N/A

Possible Drawbacks

None that I am aware of. This is just a minor version bump of npm in the dependencies for the build scripts.

Verification Process

I successfully built Atom with only Python 3 installed on my system using the changes in this PR.

Release Notes

N/A because not end-user facing? But this could work:

  • Atom can now be built using Python 3. Ensures Atom can be built on upcoming OS releases without Python 2, such as Ubuntu 20.10 or Debian 11.

npm as of 6.14.2 has node-gyp 5.1.0, which now supports Python 3.
@DeeDeeG
Copy link
Contributor Author

@DeeDeeG DeeDeeG commented May 8, 2020

cc @lkashef.

This, along with #20670, are the final pieces of the puzzle to be fully ready for a "Python 3" future, while remaining fully compatible with Python 2.

@lkashef
Copy link
Contributor

@lkashef lkashef commented May 8, 2020

Thanks @DeeDeeG

I reviewed the PR and CI, the CI is mainly failing due to a known flaky test on Windows + Slow ubuntu servers.

Once the tests pass, I will go ahead and merge this.

@lkashef lkashef merged commit d21d678 into atom:master May 12, 2020
1 check passed
@DeeDeeG
Copy link
Contributor Author

@DeeDeeG DeeDeeG commented May 12, 2020

Now that this is merged, I suppose I can update the review PR (#20716) to say so.

@lkashef
Copy link
Contributor

@lkashef lkashef commented May 12, 2020

@DeeDeeG Yeah sure, just taking it a step by step

@sgheidi

This comment has been minimized.

@DeeDeeG

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants