Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multi cursor correct setting #20804

Merged
merged 1 commit into from Jun 12, 2020
Merged

Conversation

UziTech
Copy link
Contributor

@UziTech UziTech commented May 24, 2020

Requirements for Contributing a Bug Fix

Identify the Bug

Multi cursor on Ctrl + Click does not work.

fixes #20803
fixes #20911
fixes #20914
fixes #20916
fixes #20918
fixes #20925

Description of the Change

check correct setting for enabling multicursor

Alternate Designs

none

Possible Drawbacks

none

Verification Process

tests and manually verified

Release Notes

Fix multicursor support on Ctrl + Click

@UziTech
Copy link
Contributor Author

@UziTech UziTech commented Jun 11, 2020

It would be really helpful if someone at @atom would comment on each PR or use one of the many ways GitHub has available for publicly tracking PRs to let people know that it is on someone's todo list and didn't just slip through the cracks as this one seems to have.

@Clinton594
Copy link

@Clinton594 Clinton594 commented Jun 12, 2020

Multi cursor not working, i would rather downgrade to the previous version.
This sucks

@UziTech
Copy link
Contributor Author

@UziTech UziTech commented Jun 12, 2020

Temporary fix:

  1. Open the console (Ctrl + Shift + I on Linux and Windows, Alt + Cmd + I on MacOS)
  2. run atom.config.set('core.editor.multiCursorOnClick', true);

@AlexNodex
Copy link

@AlexNodex AlexNodex commented Jun 12, 2020

Temporary fix:

1. Open the console (Ctrl + Shift + I)

2. run `atom.config.set('core.editor.multiCursorOnClick', true);`

This changes the config.cson file and adds the lines required but at a different position and a different tab value....

It works nicely though while the powers that be fix it! Thanks :D

@lkashef lkashef self-assigned this Jun 12, 2020
@lkashef lkashef merged commit 527af1a into atom:master Jun 12, 2020
1 check passed
@lkashef
Copy link
Contributor

@lkashef lkashef commented Jun 12, 2020

Hey @UziTech, thank you for the contribution and support 🙇‍♂️


We are working on getting this to Atom Nightly ASAP, however the temporary workaround should work smoothly, until the fix is propagated to beta and stable.

lkashef added a commit that referenced this issue Jun 12, 2020
fix multi cursor correct setting
caleb531 added a commit to caleb531/dotfiles that referenced this issue Jun 16, 2020
@joallard
Copy link

@joallard joallard commented Jun 22, 2020

I wasn't able to use any of the shortcuts to open the console on macOS.

However:

  • Opening menu Atom > Config... (opens config.cson)
  • Indent editor: into core:
  • Add editor: \n multiCursorOnClick: true inside core:

image

(is currently in *.editor instead of *.core.editor) will make it work on save right away.

@UziTech
Copy link
Contributor Author

@UziTech UziTech commented Jun 22, 2020

It looks like the default shortcut to open the console on MacOS is Alt + Cmd + I

@SharpSwan
Copy link

@SharpSwan SharpSwan commented Jul 8, 2020

I wasn't able to use any of the shortcuts to open the console on macOS.

However:

  • Opening menu Atom > Config... (opens config.cson)
  • Indent editor: into core:
  • Add editor: \n multiCursorOnClick: true inside core:

image

(is currently in *.editor instead of *.core.editor) will make it work on save right away.

thank you very much. I fixed this problem with your answer.

@rayonnunes
Copy link

@rayonnunes rayonnunes commented Jul 15, 2020

The multi cursor is working on my Ubuntu 20.04 only with the Ctrl + Shift + Click command.
I couldn't find that command in the "Keybindings" menu, how do I switch back to Ctrl + Click?

@lkashef
Copy link
Contributor

@lkashef lkashef commented Jul 16, 2020

@rayonnunes This should be fixed in the current stable and beta without modifying config.cson

@BryantIT
Copy link

@BryantIT BryantIT commented Aug 25, 2020

Temporary fix:

  1. Open the console (Ctrl + Shift + I on Linux and Windows, Alt + Cmd + I on MacOS)
  2. run atom.config.set('core.editor.multiCursorOnClick', true);

This does not work for me. It used to when I first had this issue but it no longer does the trick. Below is my config:

core:
    disabledPackages: [
      "language-babel"
      "language-javascript-jsx"
    ]
    editor:
      multiCursorOnClick: true
    telemetryConsent: "limited"
    themes: [
      "one-dark-ui"
      "ubik-hackerman-syntax"
    ]

@UziTech
Copy link
Contributor Author

@UziTech UziTech commented Aug 25, 2020

@BryantIT the regular setting should work in the latest release of Atom v1.50.0. Settings -> Editor -> Multi Cursor On Click

image

@BryantIT
Copy link

@BryantIT BryantIT commented Aug 25, 2020

@UziTech It should, but it does not.
multicursor
atomversion

If I move the multiclick out of core and into the other editor column, atom won't load. If I move it up the hierarchy within the core it moves back when I restart Atom.

@UziTech
Copy link
Contributor Author

@UziTech UziTech commented Aug 25, 2020

It might be something else taking over the Ctrl/Cmd key like hyperclick

@lkashef lkashef removed their assignment Aug 25, 2020
@TrevorJTClarke
Copy link

@TrevorJTClarke TrevorJTClarke commented Sep 23, 2020

Im using 1.51.0 after an update and multicursor work-around described above is no longer working.
I was able to get multicursor working with steps above -- adding to config in a couple places, and also using dev tools.
Nothing i do allows multicursor to work... Any ideas?

@jeff-hykin
Copy link

@jeff-hykin jeff-hykin commented Sep 23, 2020

I've used a multi cursor extension as a workaround. Haven't confirmed on 1.51.0 though.

@Dusch4593
Copy link

@Dusch4593 Dusch4593 commented Oct 10, 2020

It might be something else taking over the Ctrl/Cmd key like hyperclick

I think you may be right, @UziTech. I went into my config.cson file and noticed that inside "* --> atom-ide-ui", the value of hyperclick[darwinTriggerKeys] was set to "metaKey". I changed the value to be a more specific key, "ctrlKey", in order to eliminate ambiguity. I can now launch multiple cursors with cmd + click. It even works after I restart Atom. The file doesn't mysteriously change:

"*":
  "atom-beautify":
    html:
      beautify_on_save: true
    ruby:
      default_beautifier: "Ruby Beautify"
  "atom-ide-ui":
        hyperclick:
            darwinTriggerKeys: "ctrlKey"
  "autocomplete-plus":
    autoActivationDelay: 5
    maxVisibleSuggestions: 5
    strictMatching: true
  core:
    disabledPackages: [
      "terminal-plus"
    ]
    editor:
      multiCursorOnClick: true
    excludeVcsIgnoredPaths: false
    themes: [
      "one-dark-ui"
      "one-light-syntax"
    ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet