Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async and await keywords to Rust highlighter #20910

Merged
merged 1 commit into from Jul 3, 2020

Conversation

slightknack
Copy link
Contributor

@slightknack slightknack commented Jun 10, 2020

Identify the Bug

See issue #20905 for more information.

Description of the Change

This PR adds support for Rust's async and await keywords to language-rust-bundled. These keywords were added to the grammar, marked as keyword.control.

Alternate Designs

Alternatively, one could choose not to highlight these keywords. The main argument that could be made is whether async and await are actually control flow keywords or function as something else.

Possible Drawbacks

None that I can think of; if there are any, feel free to comment.

Verification Process

This is a very simple change. I rebuilt the parser and everything was functional, including the new keywords.

Release Notes

Rust's async and await keywords are now highlighted.

This commit adds support for Rust's `async` and `await` keywords to `language-rust-bundled`. See atom#20905 for more information.
@darangi darangi added the triaged label Jul 3, 2020
@darangi darangi merged commit 0fe5533 into atom:master Jul 3, 2020
1 check passed
@wow6600
Copy link

@wow6600 wow6600 commented Aug 31, 2020

Identify the Bug

See issue #20905 for more information.

Description of the Change

This PR adds support for Rust's async and await keywords to language-rust-bundled. These keywords were added to the grammar, marked as keyword.control.

Alternate Designs

Alternatively, one could choose not to highlight these keywords. The main argument that could be made is whether async and await are actually control flow keywords or function as something else.

Possible Drawbacks

None that I can think of; if there are any, feel free to comment.

Verification Process

This is a very simple change. I rebuilt the parser and everything was functional, including the new keywords.

Release Notes

Rust's async and await keywords are now highlighted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants