Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ settings-view@0.261.5 #21096

Merged

Conversation

darangi
Copy link
Contributor

@darangi darangi commented Jul 21, 2020

Resolves the electron upgrade blocker

@UziTech
Copy link
Contributor

UziTech commented Jul 21, 2020

Could this also get looked at?

atom/settings-view#1144

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Jul 22, 2020

I tested this. I can confirm the fix worked for me.

(On a branch I made with this and #21095 merged into electron-6.1.12-bump-electron-packager-from-git, both bugs went away. 👍)

  • Find in project --> Find and Replace in project works now, tested with Electron 6.
  • Package info/settings view can be scrolled, tested with Electron 6.

My build artifacts are here: https://dev.azure.com/DeeDeeG/b/_build/results?buildId=149&view=artifacts&type=publishedArtifacts

@darangi darangi merged commit bc4309b into electron-6.1.12-bump-electron-packager-from-git Jul 22, 2020
1 check passed
@sadick254 sadick254 deleted the settings-view-0.261.5 branch Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants