Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build template #21230

Merged
merged 9 commits into from Sep 4, 2020
Merged

CI build template #21230

merged 9 commits into from Sep 4, 2020

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Aug 29, 2020

The build template cherry-picked from #21081.

See that pull request for more information.

@aminya aminya changed the title CI bootstrap template CI build template Aug 29, 2020
@aminya aminya changed the title CI build template CI build and publish template Aug 29, 2020
@aminya aminya changed the title CI build and publish template CI build template Aug 29, 2020
@sadick254 sadick254 merged commit 3179ab4 into atom:master Sep 4, 2020
1 check passed
Copy link
Contributor

@DeeDeeG DeeDeeG left a comment

Sorry, we missed something here. It wasn't obvious to us, since we never code sign over at our fork.

cc @sadick254 this suggested change should get builds passing again on the Production and Nightly pipelines. (Also: without this change, builds are not being code-signed on macOS and Windows.)

I can open a PR to address this.

displayName: Build Atom
env:
GITHUB_TOKEN: $(GITHUB_TOKEN)
IS_RELEASE_BRANCH: $(IsReleaseBranch)
IS_SIGNED_ZIP_BRANCH: $(IsSignedZipBranch)
ATOM_RELEASE_VERSION: $(ReleaseVersion)

Copy link
Contributor

@DeeDeeG DeeDeeG Sep 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this env: block, we should additionally be passing in all of the following:

          ATOM_MAC_CODE_SIGNING_CERT_DOWNLOAD_URL: $(ATOM_MAC_CODE_SIGNING_CERT_DOWNLOAD_URL)
          ATOM_MAC_CODE_SIGNING_CERT_PASSWORD: $(ATOM_MAC_CODE_SIGNING_CERT_PASSWORD)
          ATOM_MAC_CODE_SIGNING_KEYCHAIN: $(ATOM_MAC_CODE_SIGNING_KEYCHAIN)
          ATOM_MAC_CODE_SIGNING_KEYCHAIN_PASSWORD: $(ATOM_MAC_CODE_SIGNING_KEYCHAIN_PASSWORD)
          ATOM_WIN_CODE_SIGNING_CERT_DOWNLOAD_URL: $(ATOM_WIN_CODE_SIGNING_CERT_DOWNLOAD_URL)
          ATOM_WIN_CODE_SIGNING_CERT_PASSWORD: $(ATOM_WIN_CODE_SIGNING_CERT_PASSWORD)

@sadick254
Copy link
Contributor

sadick254 commented Sep 5, 2020

@DeeDeeG sure, that would be great

@aminya aminya mentioned this pull request Sep 5, 2020
@aminya
Copy link
Contributor Author

aminya commented Sep 5, 2020

I made a patch in #21264. Secret variables in Azure are kinda weird. I wish they made things standardize instead of introducing a different syntax for everything.

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Sep 5, 2020

@sadick254 The PR @aminya posted looks good to me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants