Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ focus-trap@6.0.1 #21256

Merged
merged 3 commits into from Sep 23, 2020
Merged

⬆️ focus-trap@6.0.1 #21256

merged 3 commits into from Sep 23, 2020

Conversation

atom-build
Copy link
Collaborator

@atom-build atom-build commented Sep 5, 2020

Bumps focus-trap from 2.4.5 to 6.0.1

@sadick254 sadick254 self-assigned this Sep 10, 2020
@sadick254 sadick254 force-pushed the focus-trap-6.0.1 branch 2 times, most recently from a3eca36 to ba0e8de Compare Sep 17, 2020
@sadick254
Copy link
Contributor

sadick254 commented Sep 18, 2020

focus-trap doesn't work as intended because of a change introduced to add a delay before autofocus. Here is the PR that introduces that change focus-trap/focus-trap#51. The api remains the same but the functionality changes.

@sadick254
Copy link
Contributor

sadick254 commented Sep 18, 2020

I have opened a PR on the focus-trap repo to fix the problem highlighted on the comment above. focus-trap/focus-trap#154. Once this is merged we should be good to bump and merge this PR.

@stefcameron
Copy link

stefcameron commented Sep 22, 2020

Please bump to focus-trap@6.1.0 and configure your traps with the new delayInitialFocus: false option. That should resolve your issue, and thanks for @sadick254's contribution to add the new option.

@sadick254
Copy link
Contributor

sadick254 commented Sep 22, 2020

@stefcameron Thank you for facilitating the change. Really appreciate the work you are doing with focus-trap

@stefcameron
Copy link

stefcameron commented Sep 22, 2020

@stefcameron Thank you for facilitating the change. Really appreciate the work you are doing with focus-trap

My pleasure!

@sadick254 sadick254 merged commit b522a45 into master Sep 23, 2020
1 check passed
@sadick254 sadick254 deleted the focus-trap-6.0.1 branch Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants