Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build template patch #21264

Merged
merged 2 commits into from Sep 6, 2020
Merged

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Sep 5, 2020

This is a patch for #21230

It includes the code signing keys in the code map and uses Azure macros for that instead. Azure does not pass secret variables to the program without using macros.

aminya added 2 commits Sep 5, 2020
Use Azure macros to interpolate the keys
Only one condition will be true
@aminya aminya mentioned this pull request Sep 5, 2020
DeeDeeG
DeeDeeG approved these changes Sep 5, 2020
Copy link
Contributor

@DeeDeeG DeeDeeG left a comment

Looks good to me.

Note to maintainers: Pull Request CI runs always skip code signing. If you want to, you can test that code-signing truly works by pushing this to a branch starting with electron-. For example: electron-test-code-signing. That will trigger the production pipeline. And branch names starting with electron- are considered a "signed zip branch" name, so the Windows and macOS apps will be signed in the CI run.

@sadick254
Copy link
Contributor

sadick254 commented Sep 6, 2020

@DeeDeeG This one just slipped through the cracks for us. Thanks for the pointer.

@sadick254 sadick254 merged commit 7607751 into atom:master Sep 6, 2020
1 check passed
@sadick254 sadick254 mentioned this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants