Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build template including patches #21269

Merged
merged 2 commits into from Sep 11, 2020

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Sep 6, 2020

#21230 including patches

This moves the secret variable to the env map. The problems of the old PR was because I did not know which variables are saved as secret in the Azure UI, and so I assumed they are available as environment variables in the shells.

Didn't notice that AC user and password are secrets variables too.

@aminya aminya changed the title CI build template patch 2 CI build template including patchs Sep 6, 2020
@aminya aminya changed the title CI build template including patchs CI build template including patches Sep 6, 2020
@aminya
Copy link
Contributor Author

aminya commented Sep 6, 2020

@sadick254 This should fix the issue. Please run a release branch CI on this so I know what's going on.

@aminya aminya mentioned this pull request Sep 6, 2020
@DeeDeeG
Copy link
Contributor

DeeDeeG commented Sep 6, 2020

Yeah, it would be great to try this on a production type of branch. (It would have to be master or electron-[something], or else CI will skip code signing.)


@aminya Here is what I looked at to troubleshoot this issue. The CI run after #21264 was merged.

@sadick254
Copy link
Contributor

sadick254 commented Sep 10, 2020

@DeeDeeG @aminya I have created a branch electron-code-signing to test this out. I have kicked off the CI https://github.visualstudio.com/Atom/_build/results?buildId=80937&view=results. If this code signs without any issues i would consider this PR ready to go.

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Sep 10, 2020

@sadick254 thanks! Looks to me like it's working.

Here's it notarizing: https://github.visualstudio.com/Atom/_build/results?buildId=80937&view=logs&j=e2cf4b02-5697-54ad-cf7c-fc2a840d53af&t=9fd275d3-5d0a-5af8-58ae-a01a7d61dbd5&l=4965

Notarizing application at /Users/runner/work/1/s/out/Atom Dev.app

No errors there. (Some test failures after that, but I would assume they are unrelated and would pass if re-run?)

(Slightly off-topic: The Linux "fail after successfully building" thing happened as well, but on closer look this electron-code-signing branch still uses Node 12.4.0 in CI, so I still think the Node 12.16.3 fix is probably correct.)

@sadick254 sadick254 merged commit ddcdeb5 into atom:master Sep 11, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants