Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Do we know what events that lead to the error?
From what I gather about #15172 we don't know why the error happened. This just adds a console.error handler |
I think a good approach would be to display the error as a notification. This way we can have visibility when the error occurs. A user will be able to create an issue from the notification modal. See https://flight-manual.atom.io/api/v1.57.0/NotificationManager/ |
I'm assuming that `addError` displays an error. I'm also logging the error on the console - for theoretical debugging in case the notification is dismissed - but maybe it's unnecessary. I renamed `event` to `error` in the `onupgradeneeded` handler
Is the console.error unnecessary now that there's a notification? |
The |
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @UziTech
Co-authored-by: Sadick <sadickjunior@gmail.com>
Co-authored-by: Sadick <sadickjunior@gmail.com>
See #15175
Resolves #15172 (although it's already closed anyways)