New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better user experience for start atom #4269

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@yongkangchen
Copy link
Member

yongkangchen commented Nov 21, 2014

as discuss at https://discuss.atom.io/t/why-is-atom-so-slow/11376/47?u=yongkangchen
By delay load and active packages, user could see window and menu faster.
Cause I usually wait window shown and click menu to open.

@yongkangchen

This comment has been minimized.

Copy link
Member Author

yongkangchen commented Nov 21, 2014

I did not read atom-shell source code, but i test and feel 200ms make me feel better.

@mark-hahn

This comment has been minimized.

Copy link
Contributor

mark-hahn commented Nov 21, 2014

200ms make me feel better.

What happens if you try to do something before it really loads?

On Thu, Nov 20, 2014 at 7:13 PM, Yongkang Chen notifications@github.com
wrote:

I did not read atom-shell source code, but i test and feel 200ms make me
feel better.


Reply to this email directly or view it on GitHub
#4269 (comment).

@yongkangchen

This comment has been minimized.

Copy link
Member Author

yongkangchen commented Nov 21, 2014

It save all the package time for window load time. And you can see window shown faster.

@yongkangchen

This comment has been minimized.

Copy link
Member Author

yongkangchen commented Nov 21, 2014

A better solution than this, is that
ipc.send('call-window-method', 'show');
move to first of static/index.js, so window always shown most quickly.

@yongkangchen

This comment has been minimized.

Copy link
Member Author

yongkangchen commented Nov 23, 2014

I record a screen video to show what I mean.
Before modify:https://drive.google.com/file/d/0B8i7zRr2bfCATG8wNDJmR3ZQb3c/view?usp=sharing
After modify:https://drive.google.com/file/d/0B8i7zRr2bfCAbG5sYnBiUG53LXc/view?usp=sharing
Combine both: https://drive.google.com/file/d/0B8i7zRr2bfCAaFBQbkxfT0JleG8/view?usp=sharing
Please notice the window show time with the dock animation down time and the editor view show time.
before modify: window show at 00:02, the editor view show at 00:02
after mofify: window show at 00:01, the editor view show at 00:02
Same start time, same editor view show time, different window show time, but make user feels quick and better.

@bthusby

This comment has been minimized.

Copy link

bthusby commented Dec 30, 2014

Please pull it sooner rather than later if it is ok! :)

@m1ga

This comment has been minimized.

Copy link

m1ga commented Jan 11, 2015

👍

@kevinsawicki kevinsawicki force-pushed the atom:master branch 2 times, most recently from dd8eda3 to d1ecafc Jan 22, 2015

@packages.loadPackages()

setTimeout =>
@packages.loadPackages()

This comment has been minimized.

@kevinsawicki

kevinsawicki Feb 4, 2015

Member

If packages are loaded after the editor window is deserialized (@deserializeEditorWindow()) then any previously open editors from packages (such as image view, archive view, etc.) won't reopen since their deserializers won't be registered until after deserialization occurs.

@kevinsawicki kevinsawicki self-assigned this Feb 4, 2015

@oktayacikalin

This comment has been minimized.

Copy link

oktayacikalin commented Feb 12, 2015

Would be really nice if you could figure out how to solve that puzzle. Having Atom open windows fast is essential when using it for occasionally opening files from the terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment