This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Respect ATOM_HOME env var for portability #5385
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
f330e20
Set ATOM_HOME env var at startup
kevinsawicki 4c53460
Use inherited ATOM_HOME env var
kevinsawicki c0ab2c4
Use ATOM_HOME when building cache path
kevinsawicki a127240
Use ATOM_HOME as config dir path
kevinsawicki 8cd7d7d
:arrow_up: apm@0.135
kevinsawicki 4acd595
Use ATOM_HOME for nohup.out location
kevinsawicki 390be55
Use ATOM_HOME when setting configDirPath
kevinsawicki 456e511
:memo: Doc ATOM_HOME
kevinsawicki 745e9c8
:memo: Default -> Defaults
kevinsawicki 76f3727
Use sibling .atom when non-standard installer location
kevinsawicki 63e618c
Add missing rootAtomFolder var
kevinsawicki 0f29439
:memo: Fix comment typos
kevinsawicki 622b396
Guard against no LOCALAPPDATA env var
kevinsawicki 888d6df
Inline compile cache path
kevinsawicki 4e10ea0
Remove unused Subscriber mixin
kevinsawicki 71333bb
Remove custom Windows behavior
kevinsawicki 83568a1
:memo: Mention ATOM_HOME
kevinsawicki 9ba1061
:memo: Add missing in
kevinsawicki a985942
Use realpath to maintain old behavior
kevinsawicki de1c6d1
Remove unused require
kevinsawicki File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't path.sep be used instead of
/
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, but does it matter in an .sh file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, you're right - I spaced on the fact this is a shell script.