New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Electron v0.33.x #8779

Merged
merged 14 commits into from Oct 16, 2015

Conversation

Projects
None yet
7 participants
@zcbenz
Member

zcbenz commented Sep 14, 2015

Node modules to update:

  • runas
  • pathwatcher
  • nslog
  • oniguruma
  • git-utils
  • spellchecker
  • scrollbar-style
  • keyboard-layout
  • atom-keymap
  • first-mate
  • scandal
  • text-buffer
  • apm
  • highlights
  • ctags

Atom packages to update:

  • bracket-matcher
  • link
  • markdown-preview
  • symbols-view
  • tree-view
  • spell-check

Fixes #8508
Fixes #7061
Fixes #3593

@gisenberg

This comment has been minimized.

Show comment
Hide comment
@gisenberg

gisenberg Sep 14, 2015

I tried to check out the CI failures for git-utils, but Janky is reporting that the repository doesn't exist. Is there a way for me to see what went wrong? I did a local build from this branch, which yielded a bunch of gateway/network connectivity errors that didn't repro on master.

Also, I have a PR to update scrollbar-style to nan 2.0 over here: atom/scrollbar-style#9

gisenberg commented Sep 14, 2015

I tried to check out the CI failures for git-utils, but Janky is reporting that the repository doesn't exist. Is there a way for me to see what went wrong? I did a local build from this branch, which yielded a bunch of gateway/network connectivity errors that didn't repro on master.

Also, I have a PR to update scrollbar-style to nan 2.0 over here: atom/scrollbar-style#9

@mnquintana

This comment has been minimized.

Show comment
Hide comment
@mnquintana

mnquintana Sep 14, 2015

Member

I tried to check out the CI failures for git-utils, but Janky is reporting that the repository doesn't exist.

You'll want to take a look at the Travis build instead of Janky: https://travis-ci.org/atom/atom/builds/80163437

Member

mnquintana commented Sep 14, 2015

I tried to check out the CI failures for git-utils, but Janky is reporting that the repository doesn't exist.

You'll want to take a look at the Travis build instead of Janky: https://travis-ci.org/atom/atom/builds/80163437

@zcbenz zcbenz changed the title from Update to Electron v0.32.x to Update to Electron v0.33.x Sep 22, 2015

@zcbenz

This comment has been minimized.

Show comment
Hide comment
@zcbenz

zcbenz Sep 22, 2015

Member

This branch now compiles on all platforms, though we still have many failing specs.

Member

zcbenz commented Sep 22, 2015

This branch now compiles on all platforms, though we still have many failing specs.

@as-cii

This comment has been minimized.

Show comment
Hide comment
@as-cii

as-cii Sep 22, 2015

Member

While having a look at the failing specs, I have noticed that this warning messages was logged out:

[51599:0922/092254:INFO:CONSOLE(0)] "::shadow pseudo-element is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source:  (0)

This could potentially break third party themes in future versions of Chrome so it's something to keep in mind the next time we upgrade electron, although it doesn't block this specific PR.

P.s. awesome work on this, @zcbenz!

Member

as-cii commented Sep 22, 2015

While having a look at the failing specs, I have noticed that this warning messages was logged out:

[51599:0922/092254:INFO:CONSOLE(0)] "::shadow pseudo-element is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source:  (0)

This could potentially break third party themes in future versions of Chrome so it's something to keep in mind the next time we upgrade electron, although it doesn't block this specific PR.

P.s. awesome work on this, @zcbenz!

@as-cii

This comment has been minimized.

Show comment
Hide comment
@as-cii

as-cii Sep 25, 2015

Member

I think that code-wise this is good to go! I'll change the label to needs-review and test this out for a couple of days.

@zcbenz: do you think there's anything else holding this up?

Member

as-cii commented Sep 25, 2015

I think that code-wise this is good to go! I'll change the label to needs-review and test this out for a couple of days.

@zcbenz: do you think there's anything else holding this up?

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Sep 25, 2015

Contributor

I'm noticing that using cmd-o to open a file/directory in a new window isn't working for me on OS X. It displays the dialog, but never opens a new window with what I select.

Contributor

nathansobo commented Sep 25, 2015

I'm noticing that using cmd-o to open a file/directory in a new window isn't working for me on OS X. It displays the dialog, but never opens a new window with what I select.

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Sep 25, 2015

Contributor

Also having problems opening an additional window via the atom command from the command line.

Contributor

nathansobo commented Sep 25, 2015

Also having problems opening an additional window via the atom command from the command line.

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Sep 26, 2015

Contributor

Fixed the opening issues... Seeing some issues positioning overlay decorations wrong... not sure it's this branch but I want to investigate.

Contributor

nathansobo commented Sep 26, 2015

Fixed the opening issues... Seeing some issues positioning overlay decorations wrong... not sure it's this branch but I want to investigate.

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Sep 26, 2015

Contributor

Ugh, specs are hanging on CI after my latest commit. Not sure what's going on there.

Also, I'm noticing that overlay decorations are positioned incorrectly to the right side of longer lines upon first loading a window, but not after reloading it.

Contributor

nathansobo commented Sep 26, 2015

Ugh, specs are hanging on CI after my latest commit. Not sure what's going on there.

Also, I'm noticing that overlay decorations are positioned incorrectly to the right side of longer lines upon first loading a window, but not after reloading it.

@thomasjo

This comment has been minimized.

Show comment
Hide comment
@thomasjo

thomasjo Sep 27, 2015

Member

@nathansobo CI failures started after @50Wliu bumped Electron to v0.33.3, so there's likely something broke in either v0.33.2 or v0.33.3. I haven't got time to investigate further right now though, sorry.

Member

thomasjo commented Sep 27, 2015

@nathansobo CI failures started after @50Wliu bumped Electron to v0.33.3, so there's likely something broke in either v0.33.2 or v0.33.3. I haven't got time to investigate further right now though, sorry.

@zcbenz

This comment has been minimized.

Show comment
Hide comment
@zcbenz

zcbenz Oct 1, 2015

Member

I believe the failing specs are caused by electron/electron#2935.

Member

zcbenz commented Oct 1, 2015

I believe the failing specs are caused by electron/electron#2935.

@as-cii

This comment has been minimized.

Show comment
Hide comment
@as-cii

as-cii Oct 1, 2015

Member

I believe the failing specs are caused by electron/electron#2935.

@zcbenz: 👏 Great finding! Do you think we can release a 0.33.4 version with electron/electron#2950?

Member

as-cii commented Oct 1, 2015

I believe the failing specs are caused by electron/electron#2935.

@zcbenz: 👏 Great finding! Do you think we can release a 0.33.4 version with electron/electron#2950?

@zcbenz

This comment has been minimized.

Show comment
Hide comment
@zcbenz

zcbenz Oct 2, 2015

Member

@zcbenz: Great finding! Do you think we can release a 0.33.4 version with electron/electron#2950?

Sure, will cut a new release today.

Member

zcbenz commented Oct 2, 2015

@zcbenz: Great finding! Do you think we can release a 0.33.4 version with electron/electron#2950?

Sure, will cut a new release today.

@thomasjo

This comment has been minimized.

Show comment
Hide comment
@thomasjo

thomasjo Oct 2, 2015

Member

@zcbenz Specs are passing now!

Member

thomasjo commented Oct 2, 2015

@zcbenz Specs are passing now!

@thomasjo

This comment has been minimized.

Show comment
Hide comment
@thomasjo

thomasjo Oct 4, 2015

Member

This seems good to go. Will test a rebased build of this today to hunt for possibly undetected regressions.

Member

thomasjo commented Oct 4, 2015

This seems good to go. Will test a rebased build of this today to hunt for possibly undetected regressions.

zcbenz and others added some commits Sep 22, 2015

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Oct 16, 2015

Contributor

The only thing failing was docs generation, which is fixed on master. Merging this now.

Contributor

nathansobo commented Oct 16, 2015

The only thing failing was docs generation, which is fixed on master. Merging this now.

nathansobo added a commit that referenced this pull request Oct 16, 2015

Merge pull request #8779 from atom/cz-electron-32
Update to Electron v0.33.x

@nathansobo nathansobo merged commit 26a5b26 into master Oct 16, 2015

3 of 5 checks passed

atom Build #2423629 failed in 1169s
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
atom-linux Build #2423630 succeeded in 361s
Details
atom-rpm Build #2423631 succeeded in 589s
Details
atom-win Build #2423632 succeeded in 1111s
Details

@nathansobo nathansobo deleted the cz-electron-32 branch Oct 16, 2015

@50Wliu 50Wliu referenced this pull request Oct 16, 2015

Merged

Update to Electron v0.34.x #9184

@thomasjo

This comment has been minimized.

Show comment
Hide comment
@thomasjo

thomasjo Oct 17, 2015

Member

Nice!

Member

thomasjo commented Oct 17, 2015

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment