New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Electron v0.34.x #9184

Merged
merged 1 commit into from Oct 22, 2015

Conversation

Projects
None yet
4 participants
@50Wliu
Member

50Wliu commented Oct 16, 2015

Coming right after #8779...I present Electron v0.34! :P
Made this because 0.34 doesn't seem to be a major bump for Atom, and I'd like to get the rest of the 0.33 changes in.

@50Wliu 50Wliu added the needs-review label Oct 16, 2015

@thomasjo

This comment has been minimized.

Show comment
Hide comment
@thomasjo

thomasjo Oct 17, 2015

Member

At first glance this looks super-promising with zero broken specs etc. I'll be testing this out for the rest of the day. Going to merge at the end of the day unless I encounter any regressions. Thanks @50Wliu 👏

Member

thomasjo commented Oct 17, 2015

At first glance this looks super-promising with zero broken specs etc. I'll be testing this out for the rest of the day. Going to merge at the end of the day unless I encounter any regressions. Thanks @50Wliu 👏

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Oct 22, 2015

Contributor

Just rebased. Will build and live on this for a bit myself.

Contributor

nathansobo commented Oct 22, 2015

Just rebased. Will build and live on this for a bit myself.

@thomasjo

This comment has been minimized.

Show comment
Hide comment
@thomasjo

thomasjo Oct 22, 2015

Member

Completely forgot that I was going to merge this. @nathansobo Let's merge this today? I've had zero problems with this branch. Also been running it for a few hours since the rebase you did — experienced zero regressions.

Member

thomasjo commented Oct 22, 2015

Completely forgot that I was going to merge this. @nathansobo Let's merge this today? I've had zero problems with this branch. Also been running it for a few hours since the rebase you did — experienced zero regressions.

nathansobo added a commit that referenced this pull request Oct 22, 2015

Merge pull request #9184 from atom/wl-electron-34
Update to Electron v0.34.x

@nathansobo nathansobo merged commit d763b7b into master Oct 22, 2015

5 checks passed

atom Build #2437454 succeeded in 1250s
Details
atom-linux Build #2437455 succeeded in 512s
Details
atom-rpm Build #2437456 succeeded in 573s
Details
atom-win Build #2437457 succeeded in 535s
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Oct 22, 2015

Contributor

Thanks for getting this going @thomasjo.

Contributor

nathansobo commented Oct 22, 2015

Thanks for getting this going @thomasjo.

@50Wliu 50Wliu deleted the wl-electron-34 branch Oct 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment