New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the package work with tree-sitter #89

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Contributor

maxbrunsfeld commented Aug 31, 2018

Problem

Previously, this package contained a lot of logic that is specific to TextMate scopes: things like finding tag names and attribute names. When we enable Tree-sitter by default, this logic won't work.

Solution

I've added a parallel implementation of the autocomplete provider for Tree-sitter. It shares the logic for finding completions, but has different logic for finding tokens like tag names and attribute tames.

@queerviolet queerviolet referenced this pull request Aug 31, 2018

Merged

Turn tree-sitter on by default #17879

12 of 12 tasks complete

@maxbrunsfeld maxbrunsfeld merged commit 4f03dca into master Aug 31, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-tree-sitter-compat branch Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment