Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Provider API specs to async #1049

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
1 participant
@rafeca
Copy link
Contributor

commented Jun 11, 2019

This PR follows a similar approach than #1048 to make the specs more resilient by waiting for specific conditions instead of just sleeping some time.

Hopefully this will address the issue reported in atom/atom#19478

@rafeca rafeca force-pushed the more-spec-fixes branch from 16417ca to 07a10a9 Jun 11, 2019

@rafeca rafeca force-pushed the more-spec-fixes branch from 07a10a9 to 74cb8a3 Jun 11, 2019

@rafeca rafeca merged commit cd7b922 into master Jun 11, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafeca rafeca deleted the more-spec-fixes branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.