Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate use of Jasmine 1.3 async helpers in favor of async/await #1051

Merged
merged 6 commits into from Jun 14, 2019

Conversation

Projects
None yet
2 participants
@nathansobo
Copy link
Contributor

commented Jun 13, 2019

馃崘'd with @rafeca

We're hoping that avoiding Jasmine's queue-based helpers and moving to async/await will help us avoid some flakiness in this package's tests that we've observed since upgrading to Electron 3.1.

We still have about 30 occurrences of waitsFor to eliminate in order for the tests to be completely free of reliance Jasmine async helpers.

rafeca and others added some commits Jun 13, 2019

Make specs asynchronous
The `waitForAutocomplete()` method used to wait an arbitrary amount of 
miliseconds, which caused build flakiness on Atom due to race 
conditions. In order to fix that, `waitForAutocomplete()` now is an 
async method that actually waits until the autocomplete modal is shown. 
In order to use it, we've needed to refactor all the tests that used 
this method to be async.

Co-Authored-By: Nathan Sobo <nathan@github.com>
@rafeca

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

I've converted the rest of the test suite to async, I'm gonna do ~10-20 runs of the tests on Travis to check if there's any flakiness (although probably the flakiness mostly happens when this these tests run on the Atom's test suite...)

@rafeca rafeca merged commit f44a136 into master Jun 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafeca rafeca deleted the ro-ns/fix-flaky-tests branch Jun 14, 2019

@rafeca

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

I haven't seen any failures, so I think we're good to go!

@nathansobo

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.