This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Don't recompute symbols or fuzzy provider tokens when editor.largeFileMode is on
#782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as-cii
force-pushed
the
as-dont-recompute-symbols-for-large-files
branch
from
93a9fe6
to
006de01
Compare
|
❤️ ⚡️ 🚢 |
34 tasks
joefitzgerald
added a commit
that referenced
this pull request
Oct 14, 2016
joefitzgerald
added a commit
that referenced
this pull request
Oct 14, 2016
joefitzgerald
added a commit
that referenced
this pull request
Oct 17, 2016
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an editor has been created and its lines tokenized, we were previously scanning the entire buffer to search for symbols or fuzzy provider tokens. This operation could be quite expensive, and its cost grew linearly with the size of the file.
(Benchmark performed by opening big.txt, 5.2MB)
With this pull request, when
largeFileModeis detected, we simply avoid scanning the buffer, which makes opening files larger than 2MB significantly faster. In the future, we might also improve this further for files smaller than 2MB by recomputing symbols or fuzzy provider tokens in chunks via request idle callbacks.For now, in conjunction with atom/atom#12933, this should fix all the remaining large files performance bottlenecks that don't concern text-buffer.
/cc: @atom/core