Add descriptionMarkdown option to specify markdown in desriptions #790

Merged
merged 3 commits into from Nov 3, 2016

Projects

None yet

3 participants

@TimvdLippe
Contributor

This PR adds support for supplying markdown in descriptions of suggestions. It supersedes #733 which originally allowed HTML to be specified.

Fixes #423
Fixes #626
Closes #733

@TimvdLippe TimvdLippe Add descriptionMarkdown option to specify markdown in desriptions
8e28259
@TimvdLippe
Contributor

Hm for some reason the build is failing on the linter, but on lines that I did not change in this PR. I did a fresh clone and branched of master.

@as-cii
Member
as-cii commented Nov 2, 2016 edited

Thanks for this @TimvdLippe!

That's really weird, maybe standard was updated and npm is picking up a newer version that has other rules? Anyways, it would be awesome if you could fix those linter warnings in this pull request. ❤️

Code-wise this looks great too! I'll give it a spin after we have a green build and then proceed with merging it. 👍

TimvdLippe added some commits Oct 31, 2016
@TimvdLippe TimvdLippe Fix linter errors
d4d0273
@TimvdLippe TimvdLippe Add missing marked dependency
3f827e7
@TimvdLippe
Contributor

@as-cii I was able to get the build going green again, enjoy!

@as-cii as-cii merged commit b5ed0c7 into atom:master Nov 3, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@as-cii
Member
as-cii commented Nov 3, 2016

Thanks @TimvdLippe! 💥 💥 💥

@TimvdLippe
Contributor

@as-cii Could you publish a new version, so I can use it in my Atom? Thanks!

@TimvdLippe TimvdLippe deleted the TimvdLippe:markdown-description branch Nov 6, 2016
@as-cii
Member
as-cii commented Nov 17, 2016

Thanks for the heads-up @TimvdLippe, this was released in autocomplete-plus 2.34.0. I have bumped the version on atom/atom too, so this will be available in the next beta release. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment