New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid querying destroyed editor in SymbolProvider spec #810

Merged
merged 1 commit into from Dec 1, 2017

Conversation

Projects
None yet
2 participants
@maxbrunsfeld
Contributor

maxbrunsfeld commented Jan 3, 2017

@leroix

This comment has been minimized.

Show comment
Hide comment
@leroix

leroix Nov 30, 2017

Contributor

@maxbrunsfeld is this still relevant? Should we go ahead and merge it?

Contributor

leroix commented Nov 30, 2017

@maxbrunsfeld is this still relevant? Should we go ahead and merge it?

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Dec 1, 2017

Contributor

Oh wow I forgot about this. I guess it didn't end up being necessary to get the tests to pass on atom/atom#13523. It still seems valid though; I think the intent in that last test was always to pass rightEditor, not editor.

Contributor

maxbrunsfeld commented Dec 1, 2017

Oh wow I forgot about this. I guess it didn't end up being necessary to get the tests to pass on atom/atom#13523. It still seems valid though; I think the intent in that last test was always to pass rightEditor, not editor.

@maxbrunsfeld maxbrunsfeld merged commit 63432d1 into master Dec 1, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-dont-touch-destroyed-editors branch Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment