Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add subsequence provider #886
Description of the Change
I wanted to get this up for feedback sooner rather than later.
This adds the subsequence provider which uses the soon-to-be-merged
I've just copied to tests over from the symbol provider and added a few where it made sense.
Currently, we don't have support for the
I think it could be okay to land a non-default provider on master that doesn't pass all the tests from the symbols provider (the tests could be commented out at first). But I like the approach of using the old tests. Once they all pass, it may make sense to clean them up if any cleanup is needed, but getting 100% passing against the old suite is a good idea for ensuring compatibility.
referenced this pull request
Sep 14, 2017
This is looking good. I like your strategy of porting all of the tests from the symbol provider. I left one suggestion for optimizing
One other thing; for all the new files that you introduce, I would recommend dropping the dependency on babel (via the
Sep 29, 2017
I think it's pretty much ready to go with the exception of a bit of dog-fooding to root out the unintuitive matches that might crop up with the new matching algo and to make sure it feels fast
All the functionality from Symbol Provider is supported, but unicode can't be turned off. That seems to be determined by a system level setting in superstring. Perhaps, we should remove that setting from autocomplete-plus? I wouldn't say that's blocking making subsequence the default default provider though.