New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer the rendering of nonvisible suggestions #903

Merged
merged 3 commits into from Oct 11, 2017

Conversation

Projects
None yet
1 participant
@leroix
Contributor

leroix commented Oct 9, 2017

Description of the Change

Change the rendering logic to render suggestions that aren't initially visible during idle time.

Alternate Designs

The designs mostly vary around when to do the rendering work that is being deferred. For instance, we could decide to do it on the first scroll event, but this seems like a more complicated implementation.

Benefits

Rendering latency between keystroke and suggestion list display should be reduced since we are rendering less before painting.

Possible Drawbacks

It's harder to test the rendering since requestIdleCallback callbacks never get called during testing because we are never idle. :(

Applicable Issues

n/a

@leroix leroix merged commit 36e41df into atom:master Oct 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@leroix leroix deleted the leroix:jr-defer-rendering-nonvisible-suggestions branch Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment