New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer rendering nonvisible suggestions until the user scrolls or selects #904

Merged
merged 1 commit into from Oct 13, 2017

Conversation

Projects
None yet
2 participants
@leroix
Contributor

leroix commented Oct 11, 2017

Description of the Change

This PR defers the rendering of additional suggestions until the user either scrolls the suggestion box or selects a suggestion outside of those initially visible.

Alternate Designs

Previously, we deferred the rendering until an idle period.

Benefits

By deferring until the user requests the additional suggestions (basically never) we save ourselves a reflow.

Possible Drawbacks

This is slightly more difficult to test since we need to trigger a scroll event to get the rest of the suggestions to render.

Applicable Issues

n/a

defer rendering nonvisible suggestions until:
 - user scrolls the suggestion box
 - user selects a suggestion that is not initially visible
@leroix

This comment has been minimized.

Show comment
Hide comment
@leroix

leroix Oct 11, 2017

Contributor
Contributor

leroix commented Oct 11, 2017

@leroix leroix merged commit 8b76021 into atom:master Oct 13, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@leroix leroix deleted the leroix:jr-defer-rendering-2 branch Oct 13, 2017

@park9140 park9140 removed the in progress label Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment