New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybind (f1) to navigate to More.. in the suggestion list. #919

Merged
merged 4 commits into from Nov 23, 2017

Conversation

Projects
None yet
2 participants
@nineway

nineway commented Nov 11, 2017

Description of the Change

There is now a keyboard shortcut (f1) to navigate to More.. in the suggestion list. It goes to the referenced documentation if there is a description block.

Alternate Designs

There is #717 that wanted to the same, however it didn't go through for some reason and as it is in CoffeScript and an older repo, I don't know why. I took inspiration from #717 and didn't come up with any other approach as it was pretty straight forward.

Benefits

Access to documentations quicker.

Possible Drawbacks

I can't come up with any possible drawbacks.

Applicable Issues

#567

@leroix

This comment has been minimized.

Show comment
Hide comment
@leroix

leroix Nov 23, 2017

Contributor

@nineway nice work on this. Thanks for including a test as well :)

Contributor

leroix commented Nov 23, 2017

@nineway nice work on this. Thanks for including a test as well :)

@leroix leroix merged commit 6b4225f into atom:master Nov 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment