New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additionalWordCharacters bug #928

Merged
merged 2 commits into from Nov 22, 2017

Conversation

Projects
None yet
1 participant
@leroix
Contributor

leroix commented Nov 19, 2017

The default provider was retrieving the global editor.nonWordCharacters setting instead of the scoped one when calculating additionalWordCharacters to pass to findWordsWithSubsequence.

See:
#924
#922
#920

We still need to ensure the language packages set the proper values for editor.nonWordCharacters.

@leroix

This comment has been minimized.

Show comment
Hide comment
@leroix

leroix Nov 20, 2017

Contributor

After more testing, I realized that this doesn't address #920.

Contributor

leroix commented Nov 20, 2017

After more testing, I realized that this doesn't address #920.

@leroix leroix merged commit dee395b into master Nov 22, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rsese rsese referenced this pull request Nov 26, 2017

Closed

atom not detecting sass/scss mixins or variables #16158

1 of 1 task complete

maxbrunsfeld added a commit that referenced this pull request Jan 13, 2018

@maxbrunsfeld maxbrunsfeld deleted the fix-additionalWordCharacters branch Jan 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment