New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation issue for navigate-to-description-more-link #953

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Projects
None yet
2 participants
@victor-cordova
Contributor

victor-cordova commented Feb 10, 2018

Related to issue 16600 from repo /atom/atom

Description of the Change

This issue solves the bug mentioned in issue. The problem arose because the .suggestion-description container doesn't exist when the user triggers the command palette, therefore a condition was needed.

Alternate Designs

Not sure if navigate-to-description-more-link could be removed from the command palette but still work with the key binding, but this would make the functionality harder to find. Open to comments.

Benefits

The error doesn't pop-up.

Possible Drawbacks

Not that I can think of.

Applicable Issues

16600

Demo

video

Fix validation issue for navigate-to-description-more-link
Related to issue 16600 from repo /atom/atom
@ungb

This comment has been minimized.

Contributor

ungb commented Feb 26, 2018

LGTM! Thanks for this contribution @victor-cordova!

@ungb ungb merged commit abdf294 into atom:master Feb 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment