Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add "none" option to trigger keys #987
Description of the Change
This adds another option to the keybindings,
This lets the user specify shortcuts themselves, without quirky behaviour with tab and enter; when using
(Note: the change itself just adds an option that won't be picked up by the keybindings construction logic)
The setting could be turned into "custom", and add another string entry for the custom key command. This was not done, because supporting the only-if-selected behaviour would have been difficult.
Alternatively, we could default to the regular always confirm there, and ignore the setting if blank (indicating the user has set their own bindings)
The enter and tab keys work when a completion pops up.
It can be confusing what "none" is for. This can be solved with documentation, or expanding the name to something like