This repository has been archived by the owner. It is now read-only.

Don't let special characters surpass wrapColumn #67

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Projects
None yet
2 participants
@samestep
Contributor

samestep commented Mar 15, 2018

Description of the Change

Before this change, if a special character occurred as its own word past the end of a line, it would not be wrapped. This change causes all groups of non-whitespace characters to be treated the same (in keeping with the rest of the implementation), so nothing is allowed to exist past the specified wrapColumn unless it is simply too long to be wrapped.

Alternate Designs

Given that the segmentText regex uses ^\s, this seems like the only reasonable solution.

Benefits

Editing LaTeX code is less annoying (see the included test).

Possible Drawbacks

None that I'm aware of.

Applicable Issues

None that I'm aware of.

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Apr 17, 2018

Thanks! Always good when you can fix a bug by removing complexity.

@maxbrunsfeld maxbrunsfeld merged commit 06be5a7 into atom:master Apr 17, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@maxbrunsfeld maxbrunsfeld self-assigned this Apr 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.