New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Select to Next / Previous Bookmark" commands #91

Merged
merged 3 commits into from Nov 17, 2017

Conversation

Projects
None yet
2 participants
@alefragnani
Contributor

alefragnani commented Oct 12, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This PR adds two new commands to the package, Select to Next Bookmark and Select to Previous Bookmark, which creates a selection range from the cursor position to the next/previous bookmark.

Alternate Designs

It is a simple design, because the command is simple. Just using the already provided setSelectedBufferRange function to create the selection.

Benefits

You can take advantage of bookmarks to also select areas that you intend to Copy/Replace text.

Possible Drawbacks

Nothing at all, since nothing has changed in the already existing code. The two new commands are isolated.

Applicable Issues

This PR Closes #24 .

@BinaryMuse

This comment has been minimized.

Show comment
Hide comment
@BinaryMuse

BinaryMuse Nov 17, 2017

Member

Thanks so much for the contribution!

Member

BinaryMuse commented Nov 17, 2017

Thanks so much for the contribution!

@BinaryMuse BinaryMuse merged commit fd268eb into atom:master Nov 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment