Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Recognize self-closing tags, take two #304
Description of the Change
This is a modified and somewhat simplified version of #257. It features different regexes to prevent catastrophic backtracking and doesn't do any start/end-range swapping.
This kind of is the alternative.
Hopefully self-closing tags will be properly recognized now.
All three tag-related regexes got pretty serious overhauls. It may be that there is not yet enough spec coverage and there is a corner case that is broken by these changes.
I implemented these changes on a fresh clone of master and tried to reproduce issue #303. Atom had no trouble opening the sample code in the file (from #303), and was still able to distinguish self-closing tags from their matched counterparts.
The changes seem to do what they intend to do.