Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for "hidden" commands #92
This allows for commands to opt-into not appear in command palette.
Frequently commands are an implementation detail, or even only a means of providing a keybinding, and do not benefit from being shown and selectable to the user from the command palette.
Options like "Vim Mode Plus: Set Input Char M" can be confusing to the user and cloud high-signal commands from surfacing in command palette results.
Additionally, showing so many commands can bog down the command palette and make it slow to start -- though there are certainly other means of improving its performance.
The name (
Released under CC0.
It's also worth noting that this depends on the metadata changes introduced in atom/atom#15383 -- though I think this shouldn't be an issue with future releases of command-palette?
This looks similar to #90, but rather than having the user configure their command palette, the package author can determine whether their commands should be shown using the new metadata API. Both should be able to co-exist.
I like this idea, but I want escape hatch.
I'm maintaining over 30 packages including vim-mode-plus.
I want hide most of vim-mode-plus command basically, but I want to keep the way to "force show all commands by ignoring hide flag" option.
I'm not completely opposed to adding an ability to hide commands, but I'm very concerned that it could create confusion and opacity about which commands exist. Do we have any more concrete examples of commands that most people would consider to be noise?
For the example of
What if we enhanced the commands system in the following way:
If we did this, then
I'm not sure if this solution would apply to other examples of noisy commands. I'd love to hear some more you've experienced @wbinnssmith to confirm or deny this proposed solution.
I can anticipate some potential enhancement ideas to this proposal, like specified some sort of typed schema for the
I think this is off-topic of original issue.
Summary: most of vmp's command is noise, I think it's good if pkg author can control visibility of command on cmd-palette, it also reduce delay of cmd-palette.
@t9md That seems reasonable. Basically my proposal doesn't really fix the noise problem in a general way. I'm sold that we want to add hidden commands.
Is somebody willing to add @t9md's escape hatch of
Nov 2, 2017
After I hide all vmp commands.
collect + render equals to total item population time.
My summary is
Then how to solve palette's delay(my thought)?
Another approach could be to allow the user to hide certain commands. Something akin to the way the user can disable the keymaps of a package could be useful.
I know there are only a handful of commands that I actually use so hiding the rest by default could save a lot of time in the render process.